This repository was archived by the owner on Aug 7, 2021. It is now read-only.
feat: enable plugin to run through {N} CLI hooks #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
approved these changes
Oct 31, 2017
5 tasks
Mitko-Kerezov
force-pushed
the
kerezov/hooks
branch
from
4b84e2c to
8129cc5
Compare
PanayotCankov
force-pushed
the
kerezov/hooks
branch
from
8f1c88e to
6eaf19a
Compare
|
rebased |
PanayotCankov
force-pushed
the
kerezov/hooks
branch
from
6eaf19a to
12af073
Compare
Instead of relying on npm scripts, rely on hooks so that certain parts of the prepare chain can be overriden. Do not skip moving `App_Resources` directory, as CLI expects it to be present in platforms and will take care of the resources inside.
sis0k0
force-pushed
the
kerezov/hooks
branch
from
12af073 to
6150c0f
Compare
|
run ci |
sis0k0
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on npm scripts, rely on hooks so that certain parts of the prepare chain can be overriden.
Do not skip moving
App_Resourcesdirectory, as CLI expects it to be present in platforms and will take care of the resources inside.Merge along with NativeScript/nativescript-cli#3116
Ping @rosen-vladimirov @sis0k0